Fix TraceTest after IBM/sarama upgrade #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielbdias could you take a look? |
|
I tested it now, and it is ok! 😄 🎉 |
danielbdias
approved these changes
Sep 4, 2023
fatsheep9146
approved these changes
Sep 4, 2023
YANG-DB
added a commit
to opensearch-project/opentelemetry-demo
that referenced
this pull request
Nov 7, 2023
* fix data-prepper image to a stable version update fluent-bit.conf parser to emmit a different field name adding support for prometheus-opensearch exporter * add error wrapping for integration script * [frontendproxy] Add opentelemetry_collector_http to envoy's cluster and expose /oltp-http/ endpoint to frontendproxy (open-telemetry#938) Co-authored-by: Austin Parker <[email protected]> * splitting up services into modules (open-telemetry#872) * WIP splitting up services - splits up services into multiple docker files - experiment with changing service definition for checkout service when kafka is enabled todo: [ ] fix checkout service to work without kafka [ ] fix services that error without feature flag service [ ] provide noop config for collector when observability backends are disabled * send to kafka only if defined Signed-off-by: Pierre Tessier <[email protected]> * only check featureflag if env is defined Signed-off-by: Pierre Tessier <[email protected]> * split featureflag and kafka services Signed-off-by: Pierre Tessier <[email protected]> * remove feature flag env var * remove extra definitions in test file * split out observability Signed-off-by: Pierre Tessier <[email protected]> * set recommendation resources based on flag Signed-off-by: Pierre Tessier <[email protected]> * add start/stop scripts Signed-off-by: Pierre Tessier <[email protected]> * split modules Signed-off-by: Pierre Tessier <[email protected]> * split into modules Signed-off-by: Pierre Tessier <[email protected]> * allows `docker compose up` for full * default full demo, optional minimal mode Signed-off-by: Pierre Tessier <[email protected]> * default full demo, optional minimal mode Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Pierre Tessier <[email protected]> Co-authored-by: Austin Parker <[email protected]> * Add trace based testing examples (open-telemetry#877) * Adding a user purchasing product trace-based test case * Adding more tests * Adding run script * Fixed yaml lint issues * Adding license header to the files * Adding trace-based tests for more services * Updating tests and adding them on the same format as the integration tests * Fixed payment tests * Fixing e2e web tests * Fixing details found by yamllint * Updating trace-based tests to refer a protobuf file instead of embedding it * Fixed data types for email test and improved test time * Structured tests per service * Added tests for frontend service following endpoints used on loadgenerator * fixing yaml lint issues * Fixing small issues on tests * fix frontend tests (open-telemetry#950) * [cartservice] Update OTel .NET to 1.5.1 (open-telemetry#957) * [cartservice] Update OTel .NET to 1.5.1 * Update .NET docker images * Update changelog * Update alpine version --------- Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Austin Parker <[email protected]> * [chore] build images for PRs (open-telemetry#955) * [chore] build images for PRs * Add missing "on:" * Fix input type * Add license header * Do not fail fast * test: comment cache-from * Revert: test: comment cache-from * Comment featureflagservice build * Revert "[cartservice] Update OTel .NET to 1.5.1 (open-telemetry#957)" This reverts commit 814a4e9. --------- Co-authored-by: Austin Parker <[email protected]> * [shippingservice] Update Rust deps and add TelemetryResourceDetector (open-telemetry#972) * Update Rust deps and add TelemetryResourceDetector * Changelog * Update min versions --------- Co-authored-by: Austin Parker <[email protected]> * shippingservice-missing-cargolock-update (open-telemetry#982) * fix: update frontendproxy's env for minimal (open-telemetry#983) * chore: update JS dependency (open-telemetry#978) Co-authored-by: Austin Parker <[email protected]> * Run Checks on main (open-telemetry#973) Co-authored-by: Austin Parker <[email protected]> * Fix flaky cartservice build (open-telemetry#984) * update dotnet builder version * update docker version * fix yaml lint * change builder image * try different qemu container * disable static web assets entirely * fix build issue * split stages and increase loglevel --------- Co-authored-by: Carter Socha <[email protected]> * rollback to dnf6 (open-telemetry#990) * Update AdService Dependencies (open-telemetry#986) * update dependencies * Update log4j version --------- Co-authored-by: Juliano Costa <[email protected]> * [FraudDetectionService] update dependencies (open-telemetry#987) * FraudDetectionService update * changelog --------- Co-authored-by: Austin Parker <[email protected]> * [LoadGenerator & RecommendatationService] update dependencies (open-telemetry#988) * Update loadgen and add metrics * Update RecommendationService * changelog --------- Co-authored-by: Austin Parker <[email protected]> * Update Email Service Dependencies (open-telemetry#989) * update ruby deps * change to slim image --------- Co-authored-by: Juliano Costa <[email protected]> * [currencyService] Update OTel dependency (open-telemetry#991) * Update currency service OTel dependency * changelog --------- Co-authored-by: Austin Parker <[email protected]> * [FeatureFlagService] Update dependencies (open-telemetry#992) * FeatureFlagService-Update dependencies * changelog --------- Co-authored-by: Austin Parker <[email protected]> * update collector to build image using ocb (open-telemetry#944) * update collector to build image using ocb The collector in this repository now uses the otel collector builder to build a custom binary which it embeds in a docker container for the demo. Still to do: - [ ] update curl command to pull builder for specific architectures - [ ] allow passing the version of the builder to use Signed-off-by: Alex Boten <[email protected]> * update build-images Signed-off-by: Alex Boten <[email protected]> * add license Signed-off-by: Alex Boten <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Austin Parker <[email protected]> * fix(tests): removing analyzer-rules as required gate for Tracebasedtesting (open-telemetry#997) * fix(tests): updating valid card validation expected status code (open-telemetry#998) Co-authored-by: Austin Parker <[email protected]> * chore(deps): update dependency stackexchange.redis to v2.6.122 (open-telemetry#1004) * fix(tests): removing unused env var on trace-based tests (open-telemetry#1002) Co-authored-by: Austin Parker <[email protected]> * TARGETARCH cannot have a default value, and set GOARCH similarly (open-telemetry#1014) * chore: Update PHP Dependencies (open-telemetry#1009) * update dependencies 1 * Update CHANGELOG.md --------- Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Austin Parker <[email protected]> * update readme (open-telemetry#1016) * chore(deps): update dependency click to v8.1.6 (open-telemetry#999) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Carter Socha <[email protected]> * chore(deps): update dependency deprecated to v1.2.14 (open-telemetry#1003) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> * chore(deps): update docker/build-push-action action to v3.3.1 (open-telemetry#1005) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> * fix(deps): update dependency com.google.api.grpc:proto-google-common-protos to v2.22.1 (open-telemetry#1012) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> * chore(deps): update dependency configargparse to v1.5.5 (open-telemetry#1000) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * chore(deps): update dotnet monorepo (open-telemetry#1006) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Austin Parker <[email protected]> * wrapper-validation-action from 1.0.6 to 1.1.0 (open-telemetry#1026) * chore(deps): update opentelemetry-dotnet monorepo to v1.5.1 (open-telemetry#1008) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * fix(deps): update dependency @grpc/grpc-js to v1.8.18 (open-telemetry#1010) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * fix(deps): update dependency cookies-next to v2.1.2 (open-telemetry#1022) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * fix(deps): update dependency org.apache.kafka:kafka-clients to v3.5.1 (open-telemetry#1023) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * fix(deps): update dependency php-di/php-di to v7.0.3 (open-telemetry#1024) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * update upstream changes Signed-off-by: YANGDB <[email protected]> * update upstream changes Signed-off-by: YANGDB <[email protected]> * update opensearch for 2.9 Signed-off-by: YANGDB <[email protected]> * issue open-telemetry#1030 is addressed please check it. (open-telemetry#1031) * Update docker-compose.minimal.yml * Update docker-compose.minimal.yml Co-authored-by: Juliano Costa <[email protected]> * Update docker-compose.minimal.yml * Update docker-compose.minimal.yml * Remove spaces --------- Co-authored-by: Juliano Costa <[email protected]> * fix(deps): update dependency react-query to v3.39.3 (open-telemetry#1025) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * [PaymentService] - Update node to LTS version and bump deps (open-telemetry#1029) * Update node to LTS version and bump deps * changelog * Changelog * Add Guance observability vendor (open-telemetry#1039) * Pin eclipse for renovate (open-telemetry#1028) * pin eclipse image * add comments --------- Co-authored-by: Juliano Costa <[email protected]> * Update trace based tests run script (open-telemetry#1018) * chore(tests): allow partial runs on trace-based test scripts * Adding option to run trace-based tests for selected services * Updating testing README * Fixing sanity checks * Fixing lint issues * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> * Update README.md with suggestions * Updating Changelog * Fixing linter issue * Fixed changelog --------- Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * update cadence (open-telemetry#1047) * update cadence * update every other * Line break should be LF (open-telemetry#1049) * Revert collector back to contrib distribution (open-telemetry#1048) * Revert collector back to contrib distribution * fix(deps): update dependency styled-components to v5.3.11 (open-telemetry#1037) * chore(deps): update composer docker tag to v2.5 (open-telemetry#1041) * chore(deps): update config-no-service (open-telemetry#1042) * chore(deps): update dependency @types/node to v18.17.3 (open-telemetry#1046) * chore(deps): update dotnet monorepo (open-telemetry#1051) * chore(deps): update dependency configargparse to v1.5.5 (open-telemetry#1043) * fix(deps): update opentelemetry-js monorepo (open-telemetry#1038) * fix(deps): update dependency com.google.api.grpc:proto-google-common-protos to v2.22.1 (open-telemetry#1045) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> * fix(deps): update dependency @grpc/grpc-js to v1.8.18 (open-telemetry#1044) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Carter Socha <[email protected]> * add path check to gha (open-telemetry#1052) * add path check to gha * get path from dockerfile * fix lint * override skip on push * remove set_output usages * fix lint * fix --------- Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * fix(deps): update opentelemetry-js monorepo (open-telemetry#1064) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> * chore(deps): update config-no-service (open-telemetry#1056) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> * chore(deps): update dotnet monorepo (open-telemetry#1059) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Carter Socha <[email protected]> * fix(deps): update dependency php-di/php-di to v7.0.3 (open-telemetry#1060) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * chore(deps): update dependency configargparse to v1.5.5 (open-telemetry#1062) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * fix(deps): update dependency com.google.api.grpc:proto-google-common-protos to v2.22.1 (open-telemetry#1065) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * [frontend] Update dependencies (open-telemetry#1054) * [frontend] Update dependencies * changelog --------- Co-authored-by: Carter Socha <[email protected]> * Typo URL for FrontendProxy (open-telemetry#1075) * [frontendproxy] Fix typo URL endpoint for FrontendProxy * Update changelog * Add Axoflow to vendors in README.md (open-telemetry#1076) Signed-off-by: Attila Szakacs <[email protected]> * [cartservice] Drop Local cart store (open-telemetry#1081) * chore: update trace based tests to test stream events (open-telemetry#1072) * Add Logz.io to listing of Demos featuring the Astronomy Shop on README.md (open-telemetry#1082) Adding Logz.io to the 'Demos featuring the Astronomy Shop' listing. Inserted per alphabetical order. Link provided with reference. * Upgrade Shopify/sarama to IBM/sarama (open-telemetry#1083) * Update Telemetry Components (open-telemetry#1085) * Update Telemetry Components * changelog --------- Co-authored-by: Carter Socha <[email protected]> * Make Microsoft.AspNetCore.TestHost package compatible with .NET6 (open-telemetry#1084) Fixes NU1202 Package Microsoft.AspNetCore.TestHost 7.0.7 is not compatible with net6.0 Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * Add link reference (open-telemetry#1088) * [cartservice] Support for Logs (open-telemetry#1086) Co-authored-by: Juliano Costa <[email protected]> * Fix TraceTest after IBM/sarama upgrade (open-telemetry#1096) * Fix TraceTest after IBM/sarama upgrade * changelog * chore(deps): update dependency @types/react to v18.2.21 (open-telemetry#1077) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * chore(deps): update dependency eslint-config-next to v13.4.19 (open-telemetry#1078) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> * update dashboards (open-telemetry#1098) Co-authored-by: Carter Socha <[email protected]> * readme: add Tracetest to demos featuring the astronomy shop (open-telemetry#1113) * prep for 1.5 release (open-telemetry#1089) * prep for 1.5 release * update dashboards * force build to test * fix gha * revert ff comment * roll back OTP version * fix ff * fix build * clarify arm runner status --------- Co-authored-by: Carter Socha <[email protected]> * update docker login (open-telemetry#1117) * inherit secretsy (open-telemetry#1118) * remove extraneous quote (open-telemetry#1119) * update quoteservice for php Release Candidate (open-telemetry#1114) * update quoteservice for php Release Candidate - update dependencies to use RC1 and latest versions of other packages - update code to work with RC1 - refactor Dockerfile to allow local dev, and document how * update changelog * markdown lint * adding container detector * adding logging, enabling internal metrics * Add env var to docker-compose.minimal --------- Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * [cartservice] Bump OTel .NET SDK to 1.6.0 (open-telemetry#1115) Co-authored-by: Juliano Costa <[email protected]> * chore(grafana): slugify dashboard name (open-telemetry#1121) * chore(deps): update dependency flask to v2.3.3 (open-telemetry#1128) * chore(deps): update dependency flask to v2.3.3 * Required werkzeug update (open-telemetry#1129) * GHA: checks workflow: explicitly pass inputs to build-images (open-telemetry#1130) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Mikko Viitanen <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Michele Azzolari <[email protected]> * fix(otelcol) prometheus metrics export descriptions (open-telemetry#1120) * fix prom metrics export descriptions Signed-off-by: Pierre Tessier <[email protected]> * fix prom metrics export descriptions Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * Update java agent version. (open-telemetry#1132) Co-authored-by: Juliano Costa <[email protected]> * 1.5 release (open-telemetry#1133) * (chore) update dependency versions (open-telemetry#1146) * update dependency versions Signed-off-by: Pierre Tessier <[email protected]> * update dependency versions Signed-off-by: Pierre Tessier <[email protected]> * update dependency versions Signed-off-by: Pierre Tessier <[email protected]> * update dependency versions Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> * (otelcol): metrics filter and transform (open-telemetry#1134) * metrics filter and transform Signed-off-by: Pierre Tessier <[email protected]> * remove filtered metric Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * (prometheus) Add OTLP write support (open-telemetry#1149) * fix indent (open-telemetry#1152) * OpenSearch Spike (open-telemetry#1151) * add opensearch * fix env * fix yamllint * fix lint * fix errors in datasource * remove stdout export * add httpcheck receiver example (open-telemetry#1162) * add httpcheck receiver example This PR adds the httpcheck receiver to the demo to produce a synthetic check against the frontendproxy endpoint. Signed-off-by: Alex Boten <[email protected]> * add changelog Signed-off-by: Alex Boten <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Austin Parker <[email protected]> * (grafana): update grafana dashboards (open-telemetry#1150) * update grafana dashboards Signed-off-by: Pierre Tessier <[email protected]> * update grafana dashboards Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Austin Parker <[email protected]> * Fix logic in GHA (open-telemetry#1172) * fix logic * refactor logic * remove extra fi * update collector configuration to use debug exporter (open-telemetry#1148) * update collector configuration to use debug exporter This replaces references to the logging exporter with the debug exporter. Signed-off-by: Alex Boten <[email protected]> * revert changes to kubernetes/opentelemetry-demo.yaml Signed-off-by: Alex Boten <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]> Co-authored-by: Pierre Tessier <[email protected]> * (chore): merge otel o11y config (open-telemetry#1173) * merge otel o11y config Signed-off-by: Pierre Tessier <[email protected]> * merge otel o11y config Signed-off-by: Pierre Tessier <[email protected]> * Update otelcol-config-extras.yml Fixed lint --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Juliano Costa <[email protected]> * Add Cedric Ziel to list of approvers (open-telemetry#1184) * update upstream changes - remove 'opensearch integration' service - update the opensearch dashboard - add opensearch+dashboard to the minimized docker-compose.yml Signed-off-by: YANGDB <[email protected]> * update upstream changes - remove 'opensearch integration' service - update the opensearch dashboard - add opensearch+dashboard to the minimized docker-compose.yml Signed-off-by: YANGDB <[email protected]> * update upstream changes - remove 'opensearch integration' service - update the opensearch dashboard - add opensearch+dashboard to the minimized docker-compose.yml - update opensearch to use a single node Signed-off-by: YANGDB <[email protected]> * update upstream changes - remove 'opensearch integration' service - update the opensearch dashboard - add opensearch+dashboard to the minimized docker-compose.yml - update opensearch to use a single node Signed-off-by: YANGDB <[email protected]> * update upstream changes - remove 'opensearch integration' service - update the opensearch dashboard - add opensearch+dashboard to the minimized docker-compose.yml - update opensearch to use a single node Signed-off-by: YANGDB <[email protected]> * update upstream changes - remove 'opensearch integration' service - update the opensearch dashboard - add opensearch+dashboard to the minimized docker-compose.yml - update opensearch to use a single node Signed-off-by: YANGDB <[email protected]> * update upstream changes - remove 'opensearch integration' service - update the opensearch dashboard - add opensearch+dashboard to the minimized docker-compose.yml - update opensearch to use a single node Signed-off-by: YANGDB <[email protected]> * remove https in favor of http Signed-off-by: YANGDB <[email protected]> * restore https Signed-off-by: YANGDB <[email protected]> * update data-prepper config files Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]> Signed-off-by: Pierre Tessier <[email protected]> Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Alex Boten <[email protected]> Signed-off-by: Attila Szakacs <[email protected]> Co-authored-by: Chi Ma <[email protected]> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Josh Lee <[email protected]> Co-authored-by: Pierre Tessier <[email protected]> Co-authored-by: Daniel Baptista Dias <[email protected]> Co-authored-by: Piotr Kiełkowicz <[email protected]> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Oscar Reyes <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Miel Donkers <[email protected]> Co-authored-by: calmius <[email protected]> Co-authored-by: Vaishali Kirtikumar Nile <[email protected]> Co-authored-by: Harlon <[email protected]> Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Attila Szakacs <[email protected]> Co-authored-by: Dotan Horovits <[email protected]> Co-authored-by: Cedric Ziel <[email protected]> Co-authored-by: Brett McBride <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Mikko Viitanen <[email protected]> Co-authored-by: Michele Azzolari <[email protected]>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* Fix TraceTest after IBM/sarama upgrade * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix: #1091.
After #1083 being merged, some attributes for the Kafka spans have changed and the TraceTests needed to be adapted.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsAppropriate documentation updates in the docsAppropriate Helm chart updates in the helm-chartsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.